content/browser/service_worker/service_worker_provider_host.cc - Issue 1135693006: Fix X11DesktopHandler::ActivateWindow on Unity for known user gestures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 1135693006: Fix X11DesktopHandler::ActivateWindow on Unity for known user gestures Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | content/public/browser/web_contents_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 6a79c56d753730f444f8e027745818d1db8ea1ea..fc741e7e191bf783d2593dc1294fba1471fa150d 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -50,8 +50,9 @@ ServiceWorkerClientInfo FocusOnUIThread(

// Focus the frame's view to make sure the frame is now considered as focused.

render_frame_host->GetView()->Focus();

- // Move the web contents to the foreground.

- web_contents->Activate();

+ // Move the web contents to the foreground. Service Workers only allow focus()

+ // to be called in reponse to a user gesture (e.g. notificationclick event).

+ web_contents->ActivateForUserGesture();

return ServiceWorkerProviderHost::GetWindowClientInfoOnUI(render_process_id,

render_frame_id);