content/browser/renderer_host/render_view_host_delegate.h - Issue 1135693006: Fix X11DesktopHandler::ActivateWindow on Unity for known user gestures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_delegate.h

Issue 1135693006: Fix X11DesktopHandler::ActivateWindow on Unity for known user gestures Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | content/browser/renderer_host/render_view_host_delegate.cc » ('j') | content/public/browser/web_contents_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_delegate.h

diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h

index 21d8a337452bdc35d1e69f9347f5e7e59dd7a398..c5d4641579241b5908b81b6a01d08f591133a1a5 100644

--- a/content/browser/renderer_host/render_view_host_delegate.h

+++ b/content/browser/renderer_host/render_view_host_delegate.h

@@ -161,8 +161,10 @@ class CONTENT_EXPORT RenderViewHostDelegate {

uint64 upload_size) {}

// The page wants the hosting window to activate/deactivate itself (it

- // called the JavaScript window.focus()/blur() method).

+ // called the JavaScript window.focus()/blur() method). Use the ForUserGesture

+ // variant if the JavaScript was running in response to a user gesture.

virtual void Activate() {}

+ virtual void ActivateForUserGesture();

virtual void Deactivate() {}

// Notification that the view has lost capture.