tools/PictureRenderer.cpp - Issue 1135693003: Revert of Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/PictureRenderer.cpp

Issue 1135693003: Revert of Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/PictureRenderer.cpp

diff --git a/tools/PictureRenderer.cpp b/tools/PictureRenderer.cpp

index 559413f9b9c17e2523050734f13c3c4fef15bd94..93701baed9450637f0e933d5fd32d1c6ecc17a6e 100644

--- a/tools/PictureRenderer.cpp

+++ b/tools/PictureRenderer.cpp

@@ -40,7 +40,7 @@

#include "sk_tool_utils.h"

static inline SkScalar scalar_log2(SkScalar x) {

- static const SkScalar log2_conversion_factor = SkScalarDiv(1, SkScalarLog(2));

+ static const SkScalar log2_conversion_factor = SkScalarInvert(SkScalarLog(2));

return SkScalarLog(x) * log2_conversion_factor;

}

« no previous file with comments | « tests/PathCoverageTest.cpp ('k') | no next file » | no next file with comments »