src/pdf/SkPDFGraphicState.cpp - Issue 1135693003: Revert of Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFGraphicState.cpp

Issue 1135693003: Revert of Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFGraphicState.cpp

diff --git a/src/pdf/SkPDFGraphicState.cpp b/src/pdf/SkPDFGraphicState.cpp

index d063c1505ec4d2d899cad3016ac76e7d867648b5..6cf66456ab2a47a75340193cb82e4ec08cf9dd08 100644

--- a/src/pdf/SkPDFGraphicState.cpp

+++ b/src/pdf/SkPDFGraphicState.cpp

@@ -201,7 +201,7 @@

SkAutoTUnref<SkPDFDict> dict(SkNEW_ARGS(SkPDFDict, ("ExtGState")));

dict->insertName("Type", "ExtGState");

- SkScalar alpha = SkScalarDiv(fAlpha, 0xFF);

+ SkScalar alpha = SkIntToScalar(fAlpha) / 0xFF;

dict->insertScalar("CA", alpha);

dict->insertScalar("ca", alpha);

« no previous file with comments | « src/pdf/SkPDFDevice.cpp ('k') | src/pdf/SkPDFShader.cpp » ('j') | no next file with comments »