src/effects/SkLightingImageFilter.cpp - Issue 1135693003: Revert of Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 1135693003: Revert of Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index 39bd6c88a1d60313e3fc64d285b5103d27260ad7..b324cc46d112aab1d6c5c845a2f4db83c27e3fc1 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -30,8 +30,8 @@

namespace {

-const SkScalar gOneThird = SkScalarInvert(SkIntToScalar(3));

-const SkScalar gTwoThirds = SkScalarDiv(SkIntToScalar(2), SkIntToScalar(3));

+const SkScalar gOneThird = SkIntToScalar(1) / 3;

+const SkScalar gTwoThirds = SkIntToScalar(2) / 3;

const SkScalar gOneHalf = 0.5f;

const SkScalar gOneQuarter = 0.25f;

« no previous file with comments | « src/effects/SkEmbossMaskFilter.cpp ('k') | src/effects/SkPerlinNoiseShader.cpp » ('j') | no next file with comments »