gm/gradients_no_texture.cpp - Issue 1135693003: Revert of Revert of stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/gradients_no_texture.cpp

Issue 1135693003: Revert of Revert of stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/gradients_no_texture.cpp

diff --git a/gm/gradients_no_texture.cpp b/gm/gradients_no_texture.cpp

index dea9a65784e0d263f33751f01d4b12d8f95db4ff..391472a0c724842dcd71c982a736dd8681188ae4 100644

--- a/gm/gradients_no_texture.cpp

+++ b/gm/gradients_no_texture.cpp

@@ -59,8 +59,8 @@

static SkShader* Make2Conical(const SkPoint pts[2], const GradData& data, SkShader::TileMode tm) {

SkPoint center0, center1;

- SkScalar radius0 = SkScalarDiv(pts[1].fX - pts[0].fX, 10);

- SkScalar radius1 = SkScalarDiv(pts[1].fX - pts[0].fX, 3);

+ SkScalar radius0 = (pts[1].fX - pts[0].fX) / 10;

+ SkScalar radius1 = (pts[1].fX - pts[0].fX) / 3;

center0.set(pts[0].fX + radius0, pts[0].fY + radius0);

center1.set(pts[1].fX - radius1, pts[1].fY - radius1);

return SkGradientShader::CreateTwoPointConical(center1, radius1,

« no previous file with comments | « gm/gradients_2pt_conical.cpp ('k') | gm/imagefiltersclipped.cpp » ('j') | no next file with comments »