components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc - Issue 1135693002: Switch //components to use SchemeIsCryptographic() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

Issue 1135693002: Switch //components to use SchemeIsCryptographic() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Include new call. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

index 5c44a5f7cd8ffca6187c1eaba03e335d5d6b9b7b..af18b217e7cd04c4b8f55a00071c61ce55f0c773 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc

@@ -129,7 +129,7 @@ TEST(ChromeNetworkDailyDataSavingMetricsTest,

// Create a fake URLRequest and fill it with the appropriate response

// headers and proxy server by executing it with fake socket data.

net::SSLSocketDataProvider ssl_socket_data_provider(net::ASYNC, net::OK);

- if (test_case.url.SchemeIsSecure())

+ if (test_case.url.SchemeIsCryptographic())

mock_socket_factory.AddSSLSocketDataProvider(&ssl_socket_data_provider);

MockRead mock_reads[] = {

MockRead(test_case.response_headers),