components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc - Issue 1135693002: Switch //components to use SchemeIsCryptographic() instead of SchemeIsSecure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

Issue 1135693002: Switch //components to use SchemeIsCryptographic() instead of SchemeIsSecure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Include new call. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

index 3d942ff1ef3972b7763e7b6818c82434541ea6c1..06ba3ba205dde896e2f6fe7b138466cded2e6780 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

@@ -112,7 +112,8 @@ bool DataReductionProxyBypassProtocol::MaybeBypassProxyAndPrepareToRetry(

net::ProxyServer::SCHEME_HTTP, request->proxy_server());

data_reduction_proxy_type_info.is_alternative = false;

data_reduction_proxy_type_info.is_fallback = false;

- data_reduction_proxy_type_info.is_ssl = request->url().SchemeIsSecure();

+ data_reduction_proxy_type_info.is_ssl =

+ request->url().SchemeIsCryptographic();

}

// TODO(bengr): Implement bypass for CONNECT tunnel.

if (data_reduction_proxy_type_info.is_ssl)

« no previous file with comments | « no previous file | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc » ('j') | no next file with comments »