Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1135653005: dart2js: Cleanups and renames in runtime code that thouches types. (Closed)

Created:
5 years, 7 months ago by floitsch
Modified:
5 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, karlklose
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Cleanups and renames in runtime code that thouches types. As a convention we use "rti" in variable names that represent internal type encodings. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/ec51cdcca32c9d05846ad260017a4ca034a8d64f

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 2

Patch Set 3 : Reupload after svn->git move. #

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -94 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/core_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/interceptors.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 15 chunks +53 lines, -53 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_rti.dart View 5 chunks +25 lines, -25 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 7 months ago (2015-05-14 07:30:27 UTC) #2
sra1
lgtm https://codereview.chromium.org/1135653005/diff/20001/sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart File sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart (right): https://codereview.chromium.org/1135653005/diff/20001/sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart#newcode110 sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart:110: /// example `is$Foo` for a class `Foo`). In ...
5 years, 7 months ago (2015-05-14 19:09:18 UTC) #3
floitsch
https://codereview.chromium.org/1135653005/diff/20001/sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart File sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart (right): https://codereview.chromium.org/1135653005/diff/20001/sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart#newcode110 sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart:110: /// example `is$Foo` for a class `Foo`). In minified ...
5 years, 7 months ago (2015-05-19 15:42:52 UTC) #4
floitsch
5 years, 7 months ago (2015-05-19 15:43:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
ec51cdcca32c9d05846ad260017a4ca034a8d64f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698