Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1135653004: pkg/(unit)test: include a copy of old matcher (Closed)

Created:
5 years, 7 months ago by kevmoo
Modified:
5 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/test.git@stable
Target Ref:
refs/heads/stable
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Patch Set 3 : another nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4020 lines, -152 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -1 line 0 comments Download
M README.md View 1 chunk +4 lines, -140 lines 0 comments Download
A lib/src/matcher.dart View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A lib/src/matcher/core_matchers.dart View 1 1 chunk +645 lines, -0 lines 0 comments Download
A lib/src/matcher/description.dart View 1 1 chunk +68 lines, -0 lines 0 comments Download
A lib/src/matcher/error_matchers.dart View 1 1 chunk +97 lines, -0 lines 0 comments Download
A lib/src/matcher/expect.dart View 1 1 chunk +177 lines, -0 lines 0 comments Download
A lib/src/matcher/future_matchers.dart View 1 1 chunk +75 lines, -0 lines 0 comments Download
A lib/src/matcher/interfaces.dart View 1 1 chunk +60 lines, -0 lines 0 comments Download
A lib/src/matcher/iterable_matchers.dart View 1 1 chunk +267 lines, -0 lines 0 comments Download
A lib/src/matcher/map_matchers.dart View 1 1 chunk +61 lines, -0 lines 0 comments Download
A lib/src/matcher/numeric_matchers.dart View 1 1 chunk +202 lines, -0 lines 0 comments Download
A lib/src/matcher/operator_matchers.dart View 1 1 chunk +113 lines, -0 lines 0 comments Download
A lib/src/matcher/pretty_print.dart View 1 1 chunk +136 lines, -0 lines 0 comments Download
A lib/src/matcher/prints_matcher.dart View 1 1 chunk +73 lines, -0 lines 0 comments Download
A lib/src/matcher/string_matchers.dart View 1 1 chunk +201 lines, -0 lines 0 comments Download
A lib/src/matcher/throws_matcher.dart View 1 1 chunk +112 lines, -0 lines 0 comments Download
A lib/src/matcher/throws_matchers.dart View 1 1 chunk +44 lines, -0 lines 0 comments Download
A lib/src/matcher/util.dart View 1 1 chunk +65 lines, -0 lines 0 comments Download
M lib/src/simple_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/unittest.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pubspec.yaml View 2 chunks +1 line, -6 lines 0 comments Download
A test/core_matchers_test.dart View 1 1 chunk +191 lines, -0 lines 0 comments Download
A test/escape_test.dart View 1 1 chunk +63 lines, -0 lines 0 comments Download
A test/future_matchers_test.dart View 1 1 chunk +75 lines, -0 lines 0 comments Download
A test/iterable_matchers_test.dart View 1 1 chunk +165 lines, -0 lines 0 comments Download
A test/matchers_minified_test.dart View 1 1 chunk +142 lines, -0 lines 0 comments Download
A test/matchers_unminified_test.dart View 1 1 chunk +139 lines, -0 lines 0 comments Download
A test/numeric_matchers_test.dart View 1 1 chunk +142 lines, -0 lines 0 comments Download
A test/operator_matchers_test.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download
A test/pretty_print_test.dart View 1 1 chunk +193 lines, -0 lines 0 comments Download
A test/prints_matcher_test.dart View 1 1 chunk +101 lines, -0 lines 0 comments Download
A test/string_matchers_test.dart View 1 1 chunk +114 lines, -0 lines 0 comments Download
A test/test_common.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download
A test/test_utils.dart View 1 1 chunk +83 lines, -0 lines 0 comments Download
A test/throws_matchers_test.dart View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
Also release 0.11.6
5 years, 7 months ago (2015-05-07 22:59:13 UTC) #2
nweiz
https://codereview.chromium.org/1135653004/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1135653004/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Merge in the last `0.11.0` release of `matcher` ...
5 years, 7 months ago (2015-05-07 23:06:58 UTC) #3
kevmoo
https://codereview.chromium.org/1135653004/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1135653004/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Merge in the last `0.11.0` release of `matcher` ...
5 years, 7 months ago (2015-05-07 23:11:38 UTC) #4
nweiz
lgtm
5 years, 7 months ago (2015-05-08 20:21:00 UTC) #5
kevmoo
5 years, 7 months ago (2015-05-08 20:24:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9b65e844a4e72c1b4b302b38de23228d1ad7d18e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698