DescriptionRevert of Make createWindow (mostly) work with OOPIF (patchset #8 id:140001 of https://codereview.chromium.org/1109213002/)
Reason for revert:
This breaks the following browser_tests:
ActivityLogApiTest.TriggerEvent
ExtensionApiTest.Events
ExtensionBrowserTest.WindowOpenExtension
WebNavigationApiTest.OpenTab
WebstoreInlineInstallerTest.ShouldBlockInlineInstallFromPopupWindow
Original issue's description:
> Make createWindow (mostly) work with OOPIF
>
> If a RemoteFrame is targeted by window.open(), we correctly plumb the navigation out of blink.
>
> We no longer assume that ChromeClient::createWindow will return a Page with a local main frame. However, there are a several places where we wouldn't have the plumbing to set the correct state even if a Page with a remote main frame was ever returned.
>
> BUG=463742
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195063
TBR=dcheng@chromium.org,esprehn@chromium.org,japhet@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463742, 485902
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195105
Patch Set 1 #
Created: 5 years, 7 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (1 generated)
|