Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1135633004: Revert of Make createWindow (mostly) work with OOPIF (Closed)

Created:
5 years, 7 months ago by tasak
Modified:
5 years, 7 months ago
Reviewers:
esprehn, Nate Chapin, dcheng
CC:
blink-reviews, mlamouri (slow - plz ping), site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Make createWindow (mostly) work with OOPIF (patchset #8 id:140001 of https://codereview.chromium.org/1109213002/) Reason for revert: This breaks the following browser_tests: ActivityLogApiTest.TriggerEvent ExtensionApiTest.Events ExtensionBrowserTest.WindowOpenExtension WebNavigationApiTest.OpenTab WebstoreInlineInstallerTest.ShouldBlockInlineInstallFromPopupWindow Original issue's description: > Make createWindow (mostly) work with OOPIF > > If a RemoteFrame is targeted by window.open(), we correctly plumb the navigation out of blink. > > We no longer assume that ChromeClient::createWindow will return a Page with a local main frame. However, there are a several places where we wouldn't have the plumbing to set the correct state even if a Page with a remote main frame was ever returned. > > BUG=463742 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195063 TBR=dcheng@chromium.org,esprehn@chromium.org,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463742, 485902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -110 lines) Patch
M Source/core/frame/LocalDOMWindow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 7 chunks +36 lines, -5 lines 0 comments Download
M Source/core/frame/Screen.cpp View 5 chunks +12 lines, -21 lines 0 comments Download
M Source/core/page/Chrome.cpp View 2 chunks +3 lines, -19 lines 0 comments Download
M Source/core/page/CreateWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/CreateWindow.cpp View 7 chunks +46 lines, -38 lines 0 comments Download
M Source/platform/PlatformScreen.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/platform/PlatformScreen.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/web/PopupContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/web/tests/data/frame-a-b-c.html View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
tasak
Created Revert of Make createWindow (mostly) work with OOPIF
5 years, 7 months ago (2015-05-08 08:01:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135633004/1
5 years, 7 months ago (2015-05-08 08:02:37 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 08:03:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195105

Powered by Google App Engine
This is Rietveld 408576698