Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/telemetry/page/page.py

Issue 113563004: Add perf tests for starting Chrome with URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test descriptions in start_with_url Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/perf/page_sets/startup_pages.json ('K') | « tools/telemetry/telemetry/page/gtest_test_results.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | tools/telemetry/telemetry/page/page_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page.py
diff --git a/tools/telemetry/telemetry/page/page.py b/tools/telemetry/telemetry/page/page.py
index 3a4b29b0b4a7d69d04a9c2f3dcbd6f27ae13b438..ec796d17524894b6439f238b7c913f238dfaa7f8 100644
--- a/tools/telemetry/telemetry/page/page.py
+++ b/tools/telemetry/telemetry/page/page.py
@@ -57,7 +57,7 @@ class Page(object):
@property
def is_local(self):
"""Returns True iff this URL is local. This includes chrome:// URLs."""
- return self._scheme == 'file' or self._scheme == 'chrome'
+ return (self._scheme in ['file', 'chrome', 'about'])
jeremy 2013/12/17 11:29:44 Don't think you need the outer parens now?
aberent 2013/12/17 17:31:27 Done.
@property
def file_path(self):
« tools/perf/page_sets/startup_pages.json ('K') | « tools/telemetry/telemetry/page/gtest_test_results.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | tools/telemetry/telemetry/page/page_runner.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698