Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/telemetry/telemetry/page/actions/page_action.py

Issue 113563004: Add perf tests for starting Chrome with URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve name of option setting methords Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/actions/page_action.py
diff --git a/tools/telemetry/telemetry/page/actions/page_action.py b/tools/telemetry/telemetry/page/actions/page_action.py
index d0b1f4a87d6af5fa10bcbb140db9ff3717a423d0..17b42efcc6a5718b9cf171ca70977fbe2be812e8 100644
--- a/tools/telemetry/telemetry/page/actions/page_action.py
+++ b/tools/telemetry/telemetry/page/actions/page_action.py
@@ -24,9 +24,25 @@ class PageAction(object):
self._timeline_marker_base_name = None
self._timeline_marker_id = None
- def CustomizeBrowserOptions(self, options):
+ def CustomizeBrowserOptionsForPageSet(self, options):
"""Override to add action-specific options to the BrowserOptions
- object."""
+ object. These options will be set for the whole page set.
+
+ If the browser is not being restarted for every page in the page set then
+ all browser options required for the action must be set here. This, however,
+ requires that they do not conflict with options require by other actions
+ used up by the page set.
+ """
+ pass
+
+ def CustomizeBrowserOptionsForSinglePage(self, options):
+ """Override to add action-specific options to the BrowserOptions
+ object. These options will be set for just the page calling the action
+
+ This will only take effect if the browser is restarted for the page calling
+ the action, so should only be used in tests that restart the browser for
+ each page.
+ """
pass
def WillRunAction(self, page, tab):
« no previous file with comments | « tools/telemetry/telemetry/page/actions/gesture_action.py ('k') | tools/telemetry/telemetry/page/actions/set_startup_url.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698