Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1135583003: Fix the issue that certain system captioning fonts are not honored by chrome. (Closed)

Created:
5 years, 7 months ago by qinmin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the issue that certain system captioning fonts are not honored by chrome. Android TypeFace object doesn't provide chrome too much information on font family. And the font family is needed for blink to override the subtitle css. This change adds all the font families that are used by the CaptioningManager. BUG=457850 Committed: https://crrev.com/c2853886b599e6c25b4f565a6c1a1ce9dc8f78ee Cr-Commit-Position: refs/heads/master@{#330023}

Patch Set 1 #

Patch Set 2 : fix test on Kitkat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/accessibility/captioning/CaptioningChangeDelegate.java View 1 2 chunks +31 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
qinmin
PTAL
5 years, 7 months ago (2015-05-13 20:51:57 UTC) #3
qinmin
PTAL
5 years, 7 months ago (2015-05-13 20:51:58 UTC) #4
David Trainor- moved to gerrit
lgtm
5 years, 7 months ago (2015-05-14 17:35:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135583003/1
5 years, 7 months ago (2015-05-14 19:57:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/23057)
5 years, 7 months ago (2015-05-14 21:41:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135583003/20001
5 years, 7 months ago (2015-05-15 01:18:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 02:16:04 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 02:16:54 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2853886b599e6c25b4f565a6c1a1ce9dc8f78ee
Cr-Commit-Position: refs/heads/master@{#330023}

Powered by Google App Engine
This is Rietveld 408576698