Improve "dcommit in git repo" error message.

Improve "dcommit in git repo" error message.

R=agable@chromium.org, iannucci@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295609

[mmoss, 2015-05-11 23:33:41]

Patchset #1 (id:1) has been deleted

[mmoss, 2015-05-11 23:34:17]

mmoss@google.com changed reviewers:
+ agable@chromium.org, mmoss@google.com

[iannucci, 2015-05-11 23:58:34]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2015-05-11 23:58:34]

lgtm, though that 'else' case is still pretty hokey.

[agable, 2015-05-12 02:02:17]

lgtm

[mmoss, 2015-05-12 16:39:12]

On 2015/05/11 23:58:34, iannucci wrote:
> lgtm, though that 'else' case is still pretty hokey.

Yeah, I was initially planning to remove the git-svn-init stuff entirely, but I
wasn't sure there would never be an instance where it wouldn't come up (e.g.
someone using depot_tools with a git-svn repo that doesn't add the git-svn-id
line for some reason?), so I opted to just emphasize the git-cl-land path, and
hopefully make it less scary overall. If you think it's OK to trim it down more,
that's fine with me.

[Michael Moss, 2015-06-09 23:06:32]

The CQ bit was checked by mmoss@chromium.org

[commit-bot: I haz the power, 2015-06-09 23:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 23:10:05]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Michael Moss, 2015-06-10 18:01:16]

PTAL. I also made detection of improper 'land' usage a little stronger, to help
avoid issues like https://code.google.com/p/chromium/issues/detail?id=498325.

[agable, 2015-06-10 18:06:05]

Slight concern about importing git-auto-svn. Otherwise, lgtm again.

https://codereview.chromium.org/1135563005/diff/40001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1135563005/diff/40001/git_cl.py#newcode46
git_cl.py:46: import git_auto_svn
Any way get_footer_svn_id can be put into a separate file, so that we're not
importing a userscript as a library? Not sure why I missed that the first time
around.

[Michael Moss, 2015-06-10 19:05:48]

Patchset #4 (id:80001) has been deleted

[Michael Moss, 2015-06-10 19:06:03]

Patchset #3 (id:60001) has been deleted

[Michael Moss, 2015-06-10 19:09:24]

> Any way get_footer_svn_id can be put into a separate file, so that we're not
> importing a userscript as a library? Not sure why I missed that the first time
> around.

I moved it to git_footers, which is technically also a user script, though is
also already being used as a module in git_auto_svn.

[agable, 2015-06-10 19:23:38]

Perfect, thanks. re-lgtm.

[Michael Moss, 2015-06-10 19:52:05]

Committed patchset #5 (id:140001) manually as 295609.