Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1135553003: Change DeterministicSocketData to no longer inherit from SocketDataProvider (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DeterministicSocketData to no longer inherit from SocketDataProvider and change the DeterministicSockets to not implement AsyncSocket. This helps make clear using the type system that the Deterministic classes are distinct from the non-Deterministic classes. Committed: https://crrev.com/08051efe5a27ee82248a45eee41a99a0943c33cf Cr-Commit-Position: refs/heads/master@{#330590}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M net/socket/socket_test_util.h View 8 chunks +14 lines, -23 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 8 chunks +27 lines, -32 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Ryan Hamilton
5 years, 7 months ago (2015-05-19 02:45:13 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/1135553003/diff/1/net/socket/socket_test_util.cc File net/socket/socket_test_util.cc (right): https://codereview.chromium.org/1135553003/diff/1/net/socket/socket_test_util.cc#newcode749 net/socket/socket_test_util.cc:749: // // written. Otherwise return the error code. ...
5 years, 7 months ago (2015-05-19 17:06:35 UTC) #3
Ryan Hamilton
Thanks! https://codereview.chromium.org/1135553003/diff/1/net/socket/socket_test_util.cc File net/socket/socket_test_util.cc (right): https://codereview.chromium.org/1135553003/diff/1/net/socket/socket_test_util.cc#newcode749 net/socket/socket_test_util.cc:749: // // written. Otherwise return the error code. ...
5 years, 7 months ago (2015-05-19 17:33:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135553003/20001
5 years, 7 months ago (2015-05-19 17:35:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/90443)
5 years, 7 months ago (2015-05-19 17:48:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135553003/40001
5 years, 7 months ago (2015-05-19 18:56:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-19 20:07:31 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 20:08:29 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08051efe5a27ee82248a45eee41a99a0943c33cf
Cr-Commit-Position: refs/heads/master@{#330590}

Powered by Google App Engine
This is Rietveld 408576698