Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1135543002: [turbofan] Use sbfx in ARM64 instruction selector (Closed)

Created:
5 years, 7 months ago by martyn.capewell
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use sbfx in ARM64 instruction selector Select sbfx for ((x << k) >> k) in ARM64 instruction selector, and similarly for ubfx. This is a more generic version of the previous sxtb/h selector. BUG= Committed: https://crrev.com/6e6d956e1199d80e3e53739958d061b6a1c36fad Cr-Commit-Position: refs/heads/master@{#28318}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add anonymous namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -29 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 4 chunks +34 lines, -15 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +42 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
martyn.capewell
5 years, 7 months ago (2015-05-07 17:45:16 UTC) #2
Benedikt Meurer
LGTM with nit. https://codereview.chromium.org/1135543002/diff/1/src/compiler/arm64/instruction-selector-arm64.cc File src/compiler/arm64/instruction-selector-arm64.cc (right): https://codereview.chromium.org/1135543002/diff/1/src/compiler/arm64/instruction-selector-arm64.cc#newcode663 src/compiler/arm64/instruction-selector-arm64.cc:663: bool TryEmitBitfieldExtract32(InstructionSelector* selector, Node* node) { ...
5 years, 7 months ago (2015-05-08 04:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135543002/20001
5 years, 7 months ago (2015-05-08 12:27:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-08 12:51:49 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 12:51:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e6d956e1199d80e3e53739958d061b6a1c36fad
Cr-Commit-Position: refs/heads/master@{#28318}

Powered by Google App Engine
This is Rietveld 408576698