Use ExtensionEnableFlow for shim initiated launches. (Mac)

Use ExtensionEnableFlow for shim initiated launches. (Mac)

Currently when launching a shim, if the extension is not enabled, the
shim quits immediately.

This CL uses the ExtensionEnableFlow which will enable terminated apps,
prompt for escalated permissions, or fail if the app is not installed.

BUG=269151
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241084

[tapted, 2013-12-12 02:41:21]

Looks really neat! Just one annoying question..

https://codereview.chromium.org/113553002/diff/1/apps/app_shim/extension_app_...
File apps/app_shim/extension_app_shim_handler_mac.cc (right):

https://codereview.chromium.org/113553002/diff/1/apps/app_shim/extension_app_...
apps/app_shim/extension_app_shim_handler_mac.cc:372: host, profile, files));
profile.. might be OK. But is it safe to reference the Host* in a Closure and
copy it out of this stack? What happens if you have upgraded permissions and
`kill -TERM` the Shim while the dialog is still showing?

[jackhou1, 2013-12-13 03:47:10]

https://codereview.chromium.org/113553002/diff/1/apps/app_shim/extension_app_...
File apps/app_shim/extension_app_shim_handler_mac.cc (right):

https://codereview.chromium.org/113553002/diff/1/apps/app_shim/extension_app_...
apps/app_shim/extension_app_shim_handler_mac.cc:372: host, profile, files));
On 2013/12/12 02:41:21, tapted wrote:
> profile.. might be OK. But is it safe to reference the Host* in a Closure and
> copy it out of this stack? What happens if you have upgraded permissions and
> `kill -TERM` the Shim while the dialog is still showing?

Done.

[tapted, 2013-12-13 05:26:58]

sweet - lgtm

[commit-bot: I haz the power, 2013-12-13 23:54:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/113553002/20001

[commit-bot: I haz the power, 2013-12-14 00:09:29]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[jackhou1, 2013-12-15 22:48:53]

benwells, please review DEPS changes for OWNERS of c/b/ui/extensions

[benwells, 2013-12-16 00:14:02]

lgtm

[commit-bot: I haz the power, 2013-12-16 00:20:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/113553002/20001

[commit-bot: I haz the power, 2013-12-16 02:03:43]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-16 02:30:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/113553002/20001

[commit-bot: I haz the power, 2013-12-16 05:03:33]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-16 22:36:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/113553002/20001

[commit-bot: I haz the power, 2013-12-17 00:26:36]

Change committed as 241084