Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Issue 1135513002: adding rect batch unit test (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@randbatch6
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M src/gpu/GrRectBatch.cpp View 1 3 chunks +36 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-07 15:49:10 UTC) #2
robertphillips
lgtm + suggestions https://codereview.chromium.org/1135513002/diff/1/src/gpu/GrRectBatch.cpp File src/gpu/GrRectBatch.cpp (right): https://codereview.chromium.org/1135513002/diff/1/src/gpu/GrRectBatch.cpp#newcode260 src/gpu/GrRectBatch.cpp:260: Don't bother initing viewMatrix and/or localMatrix ...
5 years, 7 months ago (2015-05-07 16:33:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135513002/20001
5 years, 7 months ago (2015-05-07 21:14:36 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 21:21:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a2532d90cf3d71286276a6659db035c51b789658

Powered by Google App Engine
This is Rietveld 408576698