Issue 1135503004: Clean up nth-index calculation in SelectorChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1135503004: Clean up nth-index calculation in SelectorChecker. (Closed)

Created:
5 years, 7 months ago by rune

Modified:
5 years, 7 months ago

Reviewers:
Timothy Loh, esprehn

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Clean up nth-index calculation in SelectorChecker. Use a 1-based index consistently to avoid +/-1 adjustments and rename countElement*Before/After to nth*Index since that is what it is used for. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195113

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -24 lines)			Patch
	M	Source/core/css/SelectorChecker.cpp	View		5 chunks	+24 lines, -24 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135503004/1

5 years, 7 months ago (2015-05-08 12:56:31 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-08 12:59:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195113