Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1135493006: Revert of [strong] Object literals create strong objects (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev, Paweł Hajdan Jr., arv (Not doing code reviews), conradw
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [strong] Object literals create strong objects (patchset #4 id:60001 of https://codereview.chromium.org/1134333005/) Reason for revert: [Sheriff] Segmentation fault on arm64 with nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/1990 Original issue's description: > [strong] Object literals create strong objects > > R=dslomov@chromium.org > BUG=v8:3956 > LOG=N > > Committed: https://crrev.com/fe6598cffb82ec4180dcc2e2310e77d07a803f96 > Cr-Commit-Position: refs/heads/master@{#28444} TBR=dslomov@chromium.org,arv@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Committed: https://crrev.com/81c080ef8e7c1a38622b870b351bb1e11b6c8a62 Cr-Commit-Position: refs/heads/master@{#28464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -183 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 9 chunks +13 lines, -34 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/preparser.h View 5 chunks +2 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-literals.cc View 12 chunks +16 lines, -27 lines 0 comments Download
D test/mjsunit/strong/literals.js View 1 chunk +0 lines, -79 lines 0 comments Download
A test/mjsunit/strong/objects.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [strong] Object literals create strong objects
5 years, 7 months ago (2015-05-19 07:35:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135493006/1
5 years, 7 months ago (2015-05-19 07:35:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 07:36:18 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 07:36:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81c080ef8e7c1a38622b870b351bb1e11b6c8a62
Cr-Commit-Position: refs/heads/master@{#28464}

Powered by Google App Engine
This is Rietveld 408576698