Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1135493005: Revert of Improve OriginAccessEntry support for IP addresses. (Closed)

Created:
5 years, 7 months ago by Mike West
Modified:
5 years, 7 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Improve OriginAccessEntry support for IP addresses. (patchset #3 id:40001 of https://codereview.chromium.org/1128913004/) Reason for revert: ASAN and ClusterFuzz do not like this patch. BUG=488783 Original issue's description: > Improve OriginAccessEntry support for IP addresses. > > The current IP address check in OriginAccessEntry is hardly robust; it > just verifies that the last character in the given host is a digit. This > patch brings in the processing from GURL::HostIsIPAddress, and adds a > number of tests to verify the behavior. > > It also notes clearly that the 'TreatIPAddressAsDomain' should never be > used outside of 'document.domain' layout tests, and even there we should > get rid of it ASAP. > > BUG=477578 > R=jochen@chromium.org, rsleevi@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195410 TBR=jochen@chromium.org,rsleevi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477578 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -202 lines) Patch
M Source/platform/weborigin/OriginAccessEntry.h View 3 chunks +0 lines, -8 lines 0 comments Download
M Source/platform/weborigin/OriginAccessEntry.cpp View 2 chunks +2 lines, -28 lines 0 comments Download
M Source/platform/weborigin/OriginAccessEntryTest.cpp View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Created Revert of Improve OriginAccessEntry support for IP addresses.
5 years, 7 months ago (2015-05-16 04:59:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135493005/1
5 years, 7 months ago (2015-05-16 04:59:07 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-16 04:59:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195435

Powered by Google App Engine
This is Rietveld 408576698