Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1135483004: [turbofan] Add AdvancedReducer::ReplaceWithValue() method and convert JSInlining to an AdvancedRedu… (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add AdvancedReducer::ReplaceWithValue() method and convert JSInlining to an AdvancedReducer. Note that this is just a duplication for now. We'll want to get rid of the NodeProperties::ReplaceWithValue() method in the long run. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/e5d5cac7d91eb369e599ae8efe65a710ad101b60 Cr-Commit-Position: refs/heads/master@{#28363}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -27 lines) Patch
M src/compiler/control-reducer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/graph-reducer.h View 3 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/graph-reducer.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.h View 2 chunks +10 lines, -3 lines 0 comments Download
M src/compiler/js-inlining.cc View 7 chunks +10 lines, -20 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years, 7 months ago (2015-05-12 11:53:48 UTC) #1
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-05-12 11:56:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135483004/20001
5 years, 7 months ago (2015-05-12 12:37:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 12:41:46 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 12:41:59 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5d5cac7d91eb369e599ae8efe65a710ad101b60
Cr-Commit-Position: refs/heads/master@{#28363}

Powered by Google App Engine
This is Rietveld 408576698