Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1135463002: Revert of Revert of Remove Scope::scope_uses_arguments_ flag (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev, rossberg, Dmitry Lomov (no reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Remove Scope::scope_uses_arguments_ flag (patchset #1 id:1 of https://codereview.chromium.org/1134453002/) Reason for revert: [Sheriff] Speculative reland - maybe this revert wasn't necessary... Original issue's description: > Revert of Remove Scope::scope_uses_arguments_ flag (patchset #1 id:1 of https://codereview.chromium.org/1124233002/) > > Reason for revert: > [Sheriff] Need to fix compilation after this revert: > https://chromium.googlesource.com/v8/v8/+/5cab6be83a44567a3ee5747d728a399025d38411 > > Original issue's description: > > Remove Scope::scope_uses_arguments_ flag > > > > Use of arguments is tracked as a variable, like any other variable. > > > > R=arv@chromium.org > > LOG=N > > BUG= > > > > Committed: https://crrev.com/d4ea33f480243fb5b7d2cca6edddcaa3e9478e29 > > Cr-Commit-Position: refs/heads/master@{#28271} > > TBR=arv@chromium.org,wingo@igalia.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/b8ff13111a34553bf17961b9550dcbb7380273f3 > Cr-Commit-Position: refs/heads/master@{#28284} TBR=arv@chromium.org,wingo@igalia.com BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
M src/preparser.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/scopes.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/scopes.cc View 5 chunks +0 lines, -10 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Revert of Remove Scope::scope_uses_arguments_ flag
5 years, 7 months ago (2015-05-07 07:56:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135463002/1
5 years, 7 months ago (2015-05-07 07:56:28 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/174)
5 years, 7 months ago (2015-05-07 07:57:33 UTC) #5
Michael Achenbach
5 years, 7 months ago (2015-05-07 07:59:03 UTC) #6
Looks like both reverts were necessary. Closing this.

Powered by Google App Engine
This is Rietveld 408576698