Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1135423002: Attempt to fix win7 about flags relaunch rendering. (Closed)

Created:
5 years, 7 months ago by Ted C
Modified:
5 years, 7 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix win7 about flags relaunch rendering. I do not have a win7 machine, so I'm assuming the issue is with rounding of some sort. Setting to more standard sizing (700 for weight to match bold) and removing the font-size declaration as it was not really needed. Also added a drop shadow above the relaunch bar...for flair! BUG=487597 Committed: https://crrev.com/3549421e5527b40fff1bf5c585650438ae0ccfff Cr-Commit-Position: refs/heads/master@{#329689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/flags.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL And would either of you happen to have a win7 machine available to see ...
5 years, 7 months ago (2015-05-13 16:12:33 UTC) #2
Dan Beam
lgtm some people choose to add more flair and we encourage that, okay? p.s. win7 ...
5 years, 7 months ago (2015-05-13 17:54:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135423002/1
5 years, 7 months ago (2015-05-13 17:59:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 19:02:21 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:03:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3549421e5527b40fff1bf5c585650438ae0ccfff
Cr-Commit-Position: refs/heads/master@{#329689}

Powered by Google App Engine
This is Rietveld 408576698