Disable screenshot uploading if there has been user input.

chrome/browser/chromeos/policy/status_uploader.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_STATUS_UPLOADER_H_
 #define CHROME_BROWSER_CHROMEOS_POLICY_STATUS_UPLOADER_H_
 
 #include "base/cancelable_callback.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 20 matching lines @@
   static const int64 kDefaultUploadDelayMs;
 
   // Constructor. |client| must be registered and must stay
   // valid and registered through the lifetime of this StatusUploader
   // object.
   StatusUploader(
       CloudPolicyClient* client,
       scoped_ptr<DeviceStatusCollector> collector,
       const scoped_refptr<base::SequencedTaskRunner>& task_runner);
 
-  ~StatusUploader();
+  virtual ~StatusUploader();
 
   // Returns the time of the last successful upload, or Time(0) if no upload
   // has ever happened.
   base::Time last_upload() const { return last_upload_; }
 
+  // Returns true if session data upload (screenshots, logs, etc) is allowed.
+  // This checks to ensure that the current session is a kiosk session, and
+  // that no user input (keyboard, mouse, touch, audio/video) has been received.
+  // Virtual to allow mocking in tests.
+  virtual bool IsSessionDataUploadAllowed();
+
+ protected:
+  // Empty constructor to be used when generating mocks.
+  StatusUploader();

[cschuet (SLOW), 2015/05/13 15:56:09]

I see the necessity to introduce this empty constructor in order to write
MockStatusUploader  without having to introduce a StatusUploader interface (I
understand that you don't want to have to pass in all those parameters into the
real constructor). But doesn't this also suggest that either StatusUploader is
not the right place for IsSessionDataUploadAllowed() or at least the screenshot
command shouldn't have a dependency on StatusUploader?

[Andrew T Wilson (Slow), 2015/05/15 09:43:51]

Removed. Thanks for the feedback - much cleaner now.

+
  private:
   // Callback invoked periodically to upload the device status from the
   // DeviceStatusCollector.
   void UploadStatus();
 
   // Invoked once a status upload has completed.
   void OnUploadCompleted(bool success);
 
   // Helper method that figures out when the next status upload should
   // be scheduled.
@@ skipping 28 matching lines @@
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate the weak pointers before any other members are destroyed.
   base::WeakPtrFactory<StatusUploader> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(StatusUploader);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_CHROMEOS_POLICY_STATUS_UPLOADER_H_