Disable screenshot uploading if there has been user input.

chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_REMOTE_COMMANDS_DEVICE_COMMAND_SCREENSHOT_JOB_H_
 #define CHROME_BROWSER_CHROMEOS_POLICY_REMOTE_COMMANDS_DEVICE_COMMAND_SCREENSHOT_JOB_H_
 
 #include <list>
 #include <map>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/task_runner.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/chromeos/policy/upload_job.h"
 #include "components/policy/core/common/remote_commands/remote_command_job.h"
 #include "google_apis/gaia/oauth2_token_service.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "ui/snapshot/snapshot.h"
 #include "url/gurl.h"
 
 namespace policy {
 
+class StatusUploader;
+
 // This class implementens a RemoteCommandJob that captures a screenshot from
 // each attached screen and uploads the collected PNG data using UploadJob to
 // the url specified in the "fileUploadUrl" field of the CommandPayload. Only
 // one instance of this command will be running at a time. The
 // RemoteCommandsQueue owns all instances of this class.
 class DeviceCommandScreenshotJob : public RemoteCommandJob,
                                    public UploadJob::Delegate {
  public:
   // When the screenshot command terminates, the result payload that gets sent
   // to the server is populated with one of the following result codes. These
@@ skipping 31 matching lines @@
         gfx::NativeWindow window,
         const gfx::Rect& source_rect,
         const ui::GrabWindowSnapshotAsyncPNGCallback& callback) = 0;
 
     // Creates a new fully configured instance of an UploadJob. This method
     // may be called any number of times.
     virtual scoped_ptr<UploadJob> CreateUploadJob(const GURL&,
                                                   UploadJob::Delegate*) = 0;
   };
 
-  explicit DeviceCommandScreenshotJob(scoped_ptr<Delegate> screenshot_delegate);
+  DeviceCommandScreenshotJob(scoped_ptr<Delegate> screenshot_delegate,
+                             StatusUploader* uploader);

[cschuet (SLOW), 2015/05/13 15:56:09]

This is quite a heavy dependency just to call a bool(void) function.  Have you
considered passing in a simple Callback<void(bool* allowed)>
is_allowed_callback. This could even be a member function weakly bound to an
instance if you have to worry about lifetime

bool allowed = false;
is_allowed_callback.Run(&allowed);

OR

You could put that method into the ScreenshotDelegate. This would probably mean
that the ScreenshotDelegate aquires a dependency on DeviceStatusCollector. Hmm.
Also I can see the argument that you may want this IsSessionDataUploadAllowed()
to be more generically available although currently the method is only called
for screenshots.

[Andrew T Wilson (Slow), 2015/05/15 09:43:51]

Moved logic into ScreenshotDelegate - good call.

   ~DeviceCommandScreenshotJob() override;
 
   // RemoteCommandJob:
   enterprise_management::RemoteCommand_Type GetType() const override;
 
  private:
   class Payload;
 
   // UploadJob::Delegate:
   void OnSuccess() override;
@@ skipping 26 matching lines @@
 
   // Caches the already completed screenshots for the different displays.
   std::map<int, scoped_refptr<base::RefCountedBytes>> screenshots_;
 
   // The Delegate is used to acquire screenshots and create UploadJobs.
   scoped_ptr<Delegate> screenshot_delegate_;
 
   // The upload job instance that will upload the screenshots.
   scoped_ptr<UploadJob> upload_job_;
 
+  // StatusUploader used to check whether screenshot uploads are allowed in
+  // this session.
+  StatusUploader* status_uploader_;
+
   base::WeakPtrFactory<DeviceCommandScreenshotJob> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceCommandScreenshotJob);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_CHROMEOS_POLICY_REMOTE_COMMANDS_DEVICE_COMMAND_SCREENSHOT_JOB_H_