Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1135393005: [Android] Enable root in perf_control.SetHighPerfMode. (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Enable root in perf_control.SetHighPerfMode. SetHighPerfMode needs root, but it currently only checks to see if we already have root rather than trying to enable it. BUG=478104 Committed: https://crrev.com/83c5ba866887f876d3cd45473a839d60b5036166 Cr-Commit-Position: refs/heads/master@{#329980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/android/pylib/perf/perf_control.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
5 years, 7 months ago (2015-05-14 22:44:26 UTC) #2
sullivan
lgtm Thanks for the quick fix!
5 years, 7 months ago (2015-05-14 22:46:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135393005/1
5 years, 7 months ago (2015-05-14 22:49:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 00:00:36 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:01:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83c5ba866887f876d3cd45473a839d60b5036166
Cr-Commit-Position: refs/heads/master@{#329980}

Powered by Google App Engine
This is Rietveld 408576698