Issue 1135393003: Revert of Remove workaround to for lower glsl support for qualcomm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1135393003: Revert of Remove workaround to for lower glsl support for qualcomm (Closed)

Created:
5 years, 7 months ago by egdaniel

Modified:
5 years, 7 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Remove workaround to for lower glsl support for qualcomm (patchset #1 id:1 of https://codereview.chromium.org/1133543004/) Reason for revert: breaks many qualcomm gms Original issue's description: > Remove workaround to for lower glsl support for qualcomm > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9770bdce776f45367c419b8dd82219eece26ca5c TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0cfe1242ee284290bde1ebe3f48626c555fdac51

Patch Set 1 #

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	src/gpu/gl/GrGLContext.cpp	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

egdaniel

Created Revert of Remove workaround to for lower glsl support for qualcomm

5 years, 7 months ago (2015-05-13 14:20:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135393003/1

5 years, 7 months ago (2015-05-13 14:21:12 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/0cfe1242ee284290bde1ebe3f48626c555fdac51

5 years, 7 months ago (2015-05-13 14:21:22 UTC) #3

egdaniel

5 years, 7 months ago (2015-05-13 15:46:17 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1138013004/ by egdaniel@google.com.

The reason for reverting is: trying once more.

Expand Messages | Collapse Messages