Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1135383002: Add the chrome.fileSystem.onVolumeListChanged event. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the chrome.fileSystem.onVolumeListChanged event. This CL adds an event which notifies extension about changed list of volumes which can be requested via chrome.fileSystem.requestFileSystem. TEST=browser_tests: *OnVolumeListChanged* BUG=440674 Committed: https://crrev.com/a1cc3a6222b0027a3fcf7cf31787950b0496b85f Cr-Commit-Position: refs/heads/master@{#330047}

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Messages

Total messages: 11 (2 generated)
mtomasz
@benwells: PTAL. Thanks.
5 years, 7 months ago (2015-05-13 12:58:00 UTC) #2
mtomasz
On 2015/05/13 12:58:00, mtomasz wrote: > @benwells: PTAL. Thanks. @benwells: Friendly ping. It's very important ...
5 years, 7 months ago (2015-05-14 10:12:09 UTC) #3
benwells
does some feature json need to be updated for this? lgtm
5 years, 7 months ago (2015-05-15 03:49:49 UTC) #4
mtomasz
AFAIK, no need. All tests pass.
5 years, 7 months ago (2015-05-15 03:53:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135383002/20001
5 years, 7 months ago (2015-05-15 03:54:20 UTC) #7
benwells
On 2015/05/15 03:53:21, mtomasz wrote: > AFAIK, no need. All tests pass. ok, on reflection ...
5 years, 7 months ago (2015-05-15 03:55:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 05:36:49 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a1cc3a6222b0027a3fcf7cf31787950b0496b85f Cr-Commit-Position: refs/heads/master@{#330047}
5 years, 7 months ago (2015-05-15 05:37:25 UTC) #10
henrika (OOO until Aug 14)
5 years, 7 months ago (2015-05-15 08:35:15 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1145563002/ by henrika@chromium.org.

The reason for reverting is: Seems to break browser_tests failed
interactive_ui_tests on
Linux Chromium OS ASan LSan Tests (1).

This CL was the best I could find in the blame list. Reverting as Chrome sheriff
to see if it helps.

See
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%2....

Powered by Google App Engine
This is Rietveld 408576698