Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: net/spdy/spdy_header_block.cc

Issue 1135373002: Updated NetLog::ParametersCallback & all related calbacks returning value as scoped_ptr<base::Value… Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_header_block.h ('k') | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_header_block.cc
diff --git a/net/spdy/spdy_header_block.cc b/net/spdy/spdy_header_block.cc
index 92c6234b9446d885c5160ade6a423a58e354e130..b7bf1d48708e1b43de1afcc8877bf6a9b2c6e1a4 100644
--- a/net/spdy/spdy_header_block.cc
+++ b/net/spdy/spdy_header_block.cc
@@ -9,18 +9,19 @@
namespace net {
-base::Value* SpdyHeaderBlockNetLogCallback(const SpdyHeaderBlock* headers,
- NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
- base::DictionaryValue* headers_dict = new base::DictionaryValue();
+scoped_ptr<base::Value> SpdyHeaderBlockNetLogCallback(
+ const SpdyHeaderBlock* headers,
+ NetLogCaptureMode capture_mode) {
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
+ scoped_ptr<base::DictionaryValue> headers_dict(new base::DictionaryValue());
for (SpdyHeaderBlock::const_iterator it = headers->begin();
it != headers->end(); ++it) {
headers_dict->SetWithoutPathExpansion(
it->first, new base::StringValue(ElideHeaderValueForNetLog(
capture_mode, it->first, it->second)));
}
- dict->Set("headers", headers_dict);
- return dict;
+ dict->Set("headers", headers_dict.Pass());
+ return dict.Pass();
}
bool SpdyHeaderBlockFromNetLogParam(
« no previous file with comments | « net/spdy/spdy_header_block.h ('k') | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698