Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Unified Diff: net/cert/ct_signed_certificate_timestamp_log_param.cc

Issue 1135373002: Updated NetLog::ParametersCallback & all related calbacks returning value as scoped_ptr<base::Value… Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/ct_signed_certificate_timestamp_log_param.h ('k') | net/cert/multi_log_ct_verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_signed_certificate_timestamp_log_param.cc
diff --git a/net/cert/ct_signed_certificate_timestamp_log_param.cc b/net/cert/ct_signed_certificate_timestamp_log_param.cc
index 288bcfc159dd82bae023ba6d414b95bfce08701d..6c4b4cdd8d13b0e81c6f9bbd274a45317db333ec 100644
--- a/net/cert/ct_signed_certificate_timestamp_log_param.cc
+++ b/net/cert/ct_signed_certificate_timestamp_log_param.cc
@@ -125,10 +125,10 @@ scoped_ptr<base::ListValue> SCTListToPrintableValues(
} // namespace
-base::Value* NetLogSignedCertificateTimestampCallback(
+scoped_ptr<base::Value> NetLogSignedCertificateTimestampCallback(
const ct::CTVerifyResult* ct_result,
NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->Set("verified_scts",
SCTListToPrintableValues(ct_result->verified_scts));
@@ -139,21 +139,22 @@ base::Value* NetLogSignedCertificateTimestampCallback(
dict->Set("unknown_logs_scts",
SCTListToPrintableValues(ct_result->unknown_logs_scts));
- return dict;
+ return dict.Pass();
}
-base::Value* NetLogRawSignedCertificateTimestampCallback(
+scoped_ptr<base::Value> NetLogRawSignedCertificateTimestampCallback(
const std::string* embedded_scts,
const std::string* sct_list_from_ocsp,
const std::string* sct_list_from_tls_extension,
NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
- SetBinaryData("embedded_scts", *embedded_scts, dict);
- SetBinaryData("scts_from_ocsp_response", *sct_list_from_ocsp, dict);
- SetBinaryData("scts_from_tls_extension", *sct_list_from_tls_extension, dict);
+ SetBinaryData("embedded_scts", *embedded_scts, dict.release());
+ SetBinaryData("scts_from_ocsp_response", *sct_list_from_ocsp, dict.release());
+ SetBinaryData("scts_from_tls_extension", *sct_list_from_tls_extension,
+ dict.release());
- return dict;
+ return dict.Pass();
}
} // namespace net
« no previous file with comments | « net/cert/ct_signed_certificate_timestamp_log_param.h ('k') | net/cert/multi_log_ct_verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698