Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: net/base/sdch_net_log_params.cc

Issue 1135373002: Updated NetLog::ParametersCallback & all related calbacks returning value as scoped_ptr<base::Value… Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/sdch_net_log_params.h ('k') | net/cert/cert_policy_enforcer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/sdch_net_log_params.cc
diff --git a/net/base/sdch_net_log_params.cc b/net/base/sdch_net_log_params.cc
index a89117ecbacce6308febc7949ee0b3ed6611076d..81f84760d815c9f4f86604810f514a107532c970 100644
--- a/net/base/sdch_net_log_params.cc
+++ b/net/base/sdch_net_log_params.cc
@@ -10,25 +10,26 @@
namespace net {
-base::Value* NetLogSdchResourceProblemCallback(SdchProblemCode problem,
- NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+scoped_ptr<base::Value> NetLogSdchResourceProblemCallback(
+ SdchProblemCode problem,
+ NetLogCaptureMode capture_mode) {
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetInteger("sdch_problem_code", problem);
dict->SetInteger("net_error", ERR_FAILED);
- return dict;
+ return dict.Pass();
}
-base::Value* NetLogSdchDictionaryFetchProblemCallback(
+scoped_ptr<base::Value> NetLogSdchDictionaryFetchProblemCallback(
SdchProblemCode problem,
const GURL& url,
bool is_error,
NetLogCaptureMode capture_mode) {
- base::DictionaryValue* dict = new base::DictionaryValue();
+ scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetInteger("sdch_problem_code", problem);
dict->SetString("dictionary_url", url.spec());
if (is_error)
dict->SetInteger("net_error", ERR_FAILED);
- return dict;
+ return dict.Pass();
}
} // namespace net
« no previous file with comments | « net/base/sdch_net_log_params.h ('k') | net/cert/cert_policy_enforcer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698