Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 1135343005: Revert of [V8] Added Script::is_opaque flag for embedders (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., serviceworker-reviews, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [V8] Added Script::is_opaque flag for embedders (patchset #5 id:80001 of https://codereview.chromium.org/1140673002/) Reason for revert: [Sheriff] Breaks chromium win compilation: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/96 Original issue's description: > [V8] Added Script::is_opaque flag for embedders > > When the page is controlled by a ServiceWorker, the ServiceWorker can return an opaque (non-CORS cross origin) resource response. > We need to treat the messages from such script resource as opaque. > > Committed: https://crrev.com/7a599c5e1242d3c5ab7515ee149623da90ae69ec > Cr-Commit-Position: refs/heads/master@{#28445} TBR=mkwst@chromium.org,jochen@chromium.org,yangguo@chromium.org,horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/91f38435ead6901c96b6a1e723b1cd1460f4543e Cr-Commit-Position: refs/heads/master@{#28449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -172 lines) Patch
M include/v8.h View 7 chunks +26 lines, -53 lines 0 comments Download
M src/accessors.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/api.cc View 5 chunks +25 lines, -21 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/compilation-cache.h View 3 chunks +6 lines, -4 lines 0 comments Download
M src/compilation-cache.cc View 6 chunks +18 lines, -11 lines 0 comments Download
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M src/debug.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.h View 2 chunks +13 lines, -9 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 7 chunks +13 lines, -18 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 5 chunks +11 lines, -22 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [V8] Added Script::is_opaque flag for embedders
5 years, 7 months ago (2015-05-18 14:54:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135343005/1
5 years, 7 months ago (2015-05-18 14:54:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 14:55:03 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 14:55:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91f38435ead6901c96b6a1e723b1cd1460f4543e
Cr-Commit-Position: refs/heads/master@{#28449}

Powered by Google App Engine
This is Rietveld 408576698