Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1135343003: Remove misleading BrowserContextKeyedAPI comment. (Closed)

Created:
5 years, 7 months ago by pneubeck (no reviews)
Modified:
5 years, 7 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove misleading BrowserContextKeyedAPI comment. The comment suggests that one can manage the factory instance using the Singleton class. That is not possible as Singleton<T> has private methods only and declares only T::GetInstance as friend. BrowserContextKeyedAPIFactory<X>::GetInstance cannot be defined by users however. That misleading comment was added here https://chromiumcodereview.appspot.com/11682005 Committed: https://crrev.com/7bd179d625b0d7422291c852c6f64b5580f2067d Cr-Commit-Position: refs/heads/master@{#330068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M extensions/browser/browser_context_keyed_api_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pneubeck (no reviews)
Yoyo, ptal
5 years, 7 months ago (2015-05-13 08:54:00 UTC) #2
pneubeck (no reviews)
Jeffrey, please owner review. Btw. what do you think about the suggested non-leaky LazyInstance? Shouldn't ...
5 years, 7 months ago (2015-05-13 08:55:34 UTC) #4
Jeffrey Yasskin
LGTM; thanks for digging to find where the comment was introduced. I *think* every use ...
5 years, 7 months ago (2015-05-13 17:00:27 UTC) #6
not at google - send to devlin
Drive-by because I'm CC'ed on this CL for some reason: yoz isn't on the team ...
5 years, 7 months ago (2015-05-13 17:08:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135343003/1
5 years, 7 months ago (2015-05-15 08:24:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 09:11:53 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 09:12:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bd179d625b0d7422291c852c6f64b5580f2067d
Cr-Commit-Position: refs/heads/master@{#330068}

Powered by Google App Engine
This is Rietveld 408576698