Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1135333006: [Smart Lock] Update strings for Save Passwords page on Android. (Closed)

Created:
5 years, 7 months ago by engedy
Modified:
5 years, 6 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Update strings for Save Passwords page on Android. BUG=486739 Committed: https://crrev.com/123b175fbb872dbe57f07c921bdadb138a058b2d Cr-Commit-Position: refs/heads/master@{#330251}

Patch Set 1 : #

Patch Set 2 : Rebase and update name for IsSmartLockBrandingEnabled(). #

Patch Set 3 : Rebase #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/PasswordUIView.java View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/password/ManageSavedPasswordsPreferences.java View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/android/password_ui_view_android.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
engedy
Garrett, could you please take a look? In particular, do you think defining the string ...
5 years, 7 months ago (2015-05-15 23:26:57 UTC) #3
Garrett Casto
LGTM, but I'm not an owner of these files.
5 years, 7 months ago (2015-05-15 23:33:20 UTC) #4
engedy
Newton, could you please review this as well as OWNER?
5 years, 7 months ago (2015-05-15 23:35:28 UTC) #6
engedy
On 2015/05/15 23:35:28, engedy wrote: > Newton, could you please review this as well as ...
5 years, 7 months ago (2015-05-15 23:37:06 UTC) #7
newt (away)
lgtm
5 years, 7 months ago (2015-05-15 23:50:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135333006/60001
5 years, 7 months ago (2015-05-15 23:59:30 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-16 00:44:31 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:30:04 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/123b175fbb872dbe57f07c921bdadb138a058b2d
Cr-Commit-Position: refs/heads/master@{#330251}

Powered by Google App Engine
This is Rietveld 408576698