ui/views/cocoa/bridged_native_widget_unittest.mm - Issue 1135333002: Suppress -Wpartial-availability warnings that arise from NSWindowDelegate methods only available on…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_native_widget_unittest.mm

Issue 1135333002: Suppress -Wpartial-availability warnings that arise from NSWindowDelegate methods only available on… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from thakis. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller_private.h ('K') | « chrome/browser/ui/cocoa/browser_window_controller_private.h ('k') | ui/views/cocoa/views_nswindow_delegate.h » ('j') | ui/views/cocoa/views_nswindow_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/cocoa/bridged_native_widget_unittest.mm

diff --git a/ui/views/cocoa/bridged_native_widget_unittest.mm b/ui/views/cocoa/bridged_native_widget_unittest.mm

index 3cf3dc2ec9e755f440312d4299d86314fe842bcf..c61b18b768ded7ca9801fbe6cb2ff9b744ccc16c 100644

--- a/ui/views/cocoa/bridged_native_widget_unittest.mm

+++ b/ui/views/cocoa/bridged_native_widget_unittest.mm

@@ -17,6 +17,7 @@

#import "ui/gfx/test/ui_cocoa_test_helper.h"

#import "ui/views/cocoa/bridged_content_view.h"

#import "ui/views/cocoa/native_widget_mac_nswindow.h"

+#import "ui/views/cocoa/views_nswindow_delegate.h"

#include "ui/views/controls/textfield/textfield.h"

#include "ui/views/ime/input_method.h"

#include "ui/views/view.h"

@@ -489,7 +490,8 @@ TEST_F(BridgedNativeWidgetSimulateFullscreenTest, FailToEnterAndExit) {

// Cocoa follows up with a failure message sent to the NSWindowDelegate (there

// is no equivalent notification for failure). Called via id so that this

// compiles on 10.6.

- id window_delegate = [window delegate];

+ ViewsNSWindowDelegate* window_delegate =

+ base::mac::ObjCCast<ViewsNSWindowDelegate>([window delegate]);

[window_delegate windowDidFailToEnterFullScreen:window];

EXPECT_FALSE(bridge()->target_fullscreen_state());