Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: ui/views/cocoa/bridged_native_widget_unittest.mm

Issue 1135333002: Suppress -Wpartial-availability warnings that arise from NSWindowDelegate methods only available on… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from thakis. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/cocoa/bridged_native_widget_unittest.mm
diff --git a/ui/views/cocoa/bridged_native_widget_unittest.mm b/ui/views/cocoa/bridged_native_widget_unittest.mm
index 3cf3dc2ec9e755f440312d4299d86314fe842bcf..1bf91db51893f24909fac3312e6076ca4ccd7d9c 100644
--- a/ui/views/cocoa/bridged_native_widget_unittest.mm
+++ b/ui/views/cocoa/bridged_native_widget_unittest.mm
@@ -490,7 +490,8 @@ TEST_F(BridgedNativeWidgetSimulateFullscreenTest, FailToEnterAndExit) {
// is no equivalent notification for failure). Called via id so that this
// compiles on 10.6.
Nico 2015/05/18 23:45:09 So I think this is the problem. The Right Fix I th
erikchen 2015/05/19 00:35:24 1. I declared the relevant methods in ui/views/coc
id window_delegate = [window delegate];
- [window_delegate windowDidFailToEnterFullScreen:window];
+ [window_delegate performSelector:@selector(windowDidFailToEnterFullScreen:)
+ withObject:window];
EXPECT_FALSE(bridge()->target_fullscreen_state());
// Now perform a successful fullscreen operation.
@@ -508,7 +509,8 @@ TEST_F(BridgedNativeWidgetSimulateFullscreenTest, FailToEnterAndExit) {
// On a failure, Cocoa sends a failure message, but then just dumps the window
// out of fullscreen anyway (in that order).
- [window_delegate windowDidFailToExitFullScreen:window];
+ [window_delegate performSelector:@selector(windowDidFailToExitFullScreen:)
+ withObject:window];
EXPECT_FALSE(bridge()->target_fullscreen_state());
[center postNotificationName:NSWindowDidExitFullScreenNotification
object:window];
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698