chrome/browser/ui/cocoa/browser_window_controller_private.h - Issue 1135333002: Suppress -Wpartial-availability warnings that arise from NSWindowDelegate methods only available on…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.h

Issue 1135333002: Suppress -Wpartial-availability warnings that arise from NSWindowDelegate methods only available on… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/mac/sdk_forward_declarations.h ('k') | ui/views/cocoa/bridged_native_widget_unittest.mm » ('j') | ui/views/cocoa/bridged_native_widget_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_private.h

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.h b/chrome/browser/ui/cocoa/browser_window_controller_private.h

index d50964fc2ae3918c3fb6fd91b1330d3fc0cd7306..a1334316319742c6c18511d6598de381cef0b2bc 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.h

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.h

@@ -164,6 +164,14 @@

// out of AppKit Fullscreen.

- (BOOL)shouldUseCustomAppKitFullscreenTransition;

+// Redeclare some methods from NSWindowDelegate to suppress

+// -Wpartial-availability warnings.

Nico 2015/05/12 22:29:38 Should this have some "// Available in 10.7, remov

erikchen 2015/05/12 22:41:39 I wrapped this in the preprocessor conditional tha

+- (void)windowDidEnterFullScreen:(NSNotification*)notification;

+- (void)windowDidExitFullScreen:(NSNotification*)notification;

+- (void)windowWillExitFullScreen:(NSNotification*)notification;

+- (void)windowDidFailToEnterFullScreen:(NSWindow*)window;

+- (void)windowDidFailToExitFullScreen:(NSWindow*)window;

@end // @interface BrowserWindowController(Private)

#endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_