Suppress -Wpartial-availability warnings that arise from NSWindowDelegate methods only available on…

ui/views/cocoa/bridged_native_widget_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_native_widget.h"
 
 #import <Cocoa/Cocoa.h>
 
 #import "base/mac/foundation_util.h"
 #import "base/mac/mac_util.h"
@@ skipping 472 matching lines @@
   EXPECT_TRUE(bridge()->target_fullscreen_state());
   [center postNotificationName:NSWindowDidExitFullScreenNotification
                         object:window];
   EXPECT_EQ(1, [window ignoredToggleFullScreenCount]);
   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   // Cocoa follows up with a failure message sent to the NSWindowDelegate (there
   // is no equivalent notification for failure). Called via id so that this
   // compiles on 10.6.
   id window_delegate = [window delegate];
-  [window_delegate windowDidFailToEnterFullScreen:window];
+  [window_delegate performSelector:@selector(windowDidFailToEnterFullScreen:)
+                        withObject:window];

[Nico, 2015/05/12 22:29:38]

why this change?

[erikchen, 2015/05/12 22:41:39]

The method windowDidFailToEnterFullScreen: is only available on 10.7+ and is
defined in a protocol. Switching to a perform-selector suppresses the warning.
If you prefer, I could use clang preprocessor directives.

[Nico, 2015/05/12 22:45:00]

Huh, if you declare it it should be possible to call it, no?

[erikchen, 2015/05/12 23:49:19]

Just to confirm: You would prefer it if I cast window_delegate to
ViewsNSWindowDelegate, add redeclarations of the relevant methods to
ViewsNSWindowDelegate, and add VIEWS_EXPORT to ViewsNSWindowDelegate?

[Nico, 2015/05/13 00:18:30]

Are you sure that you need the cast and the export? Does just adding the
declaration there suffice?

[erikchen, 2015/05/13 00:26:21]

Ah, they are not necessary. 

One caveat: This class currently doesn't include "views_nswindow_delegate.h",
which is where the redeclaration would happen. I can add an include, but there
will be no visibility as to why the include is necessary. I guess I could wrap
the include the ifdefs? It's not very clear that we're using the redeclarations
in views_nswindow_delegate.h to suppress a warning on this "id window_delegate".

[erikchen, 2015/05/13 16:56:43]

Hm. Removing NSWindowDelegateFullScreenAdditions from sdk_forward_declarations.h
prevents this code from compiling against 10.6 SDK. That...doesn't make sense to
me. I don't understand why defining a protocol that is never used removes the
compile failure. The code was introduced here:
https://codereview.chromium.org/665823002/

The name of the protocol itself doesn't matter - I changed it to "sdfasdf" and
its existence still removed the compile failure.

I think that switching to performSelector: and removing this "magic" protocol
from sdk_forward_declarations.h is the best solution. wdyt?

   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   // Now perform a successful fullscreen operation.
   [center postNotificationName:NSWindowWillEnterFullScreenNotification
                         object:window];
   EXPECT_TRUE(bridge()->target_fullscreen_state());
   [center postNotificationName:NSWindowDidEnterFullScreenNotification
                         object:window];
   EXPECT_TRUE(bridge()->target_fullscreen_state());
 
   // And try to get out.
   [center postNotificationName:NSWindowWillExitFullScreenNotification
                         object:window];
   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   // On a failure, Cocoa sends a failure message, but then just dumps the window
   // out of fullscreen anyway (in that order).
-  [window_delegate windowDidFailToExitFullScreen:window];
+  [window_delegate performSelector:@selector(windowDidFailToExitFullScreen:)
+                        withObject:window];
   EXPECT_FALSE(bridge()->target_fullscreen_state());
   [center postNotificationName:NSWindowDidExitFullScreenNotification
                         object:window];
   EXPECT_EQ(1, [window ignoredToggleFullScreenCount]);  // No change.
   EXPECT_FALSE(bridge()->target_fullscreen_state());
 
   widget_->CloseNow();
 }
 
 }  // namespace test
 }  // namespace views