chrome/browser/component_updater/component_updater_service.cc - Issue 113533004: Clean up empty directories after install and on errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_updater_service.cc

Issue 113533004: Clean up empty directories after install and on errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clean up job files. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/component_updater/component_updater_service.cc

diff --git a/chrome/browser/component_updater/component_updater_service.cc b/chrome/browser/component_updater/component_updater_service.cc

index dff725f371cbafcae22f131268f7afed3e406a68..1a91e1994592292b213e0417b25d0f12bdce8a34 100644

--- a/chrome/browser/component_updater/component_updater_service.cc

+++ b/chrome/browser/component_updater/component_updater_service.cc

@@ -954,8 +954,8 @@ void CrxUpdateService::Install(scoped_ptr<CRXContext> context,

context->fingerprint,

component_patcher_.get(),

context->installer);

- if (!base::DeleteFile(crx_path, false))

- NOTREACHED() << crx_path.value();

+ component_updater::DeleteFileAndParentDirectoryIfEmpty(crx_path);

Sorin Jianu 2013/12/15 23:12:35 I will add a unit test to verify this post conditi

Sorin Jianu 2013/12/15 23:15:16 Actually, I can't for now.

// Why unretained? See comment at top of file.

BrowserThread::PostDelayedTask(

BrowserThread::UI,