Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 113533004: Clean up empty directories after install and on errors (Closed)

Created:
7 years ago by Sorin Jianu
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Clean up empty directories after install and on errors BUG=327880 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241142

Patch Set 1 #

Patch Set 2 : clean up job files. #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M chrome/browser/component_updater/background_downloader_win.cc View 1 2 3 3 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_utils.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_updater_utils.cc View 1 2 2 chunks +13 lines, -1 line 2 comments Download

Messages

Total messages: 13 (0 generated)
Sorin Jianu
It turns out that on successful installs, only the file was cleaned up, and we ...
7 years ago (2013-12-15 23:02:20 UTC) #1
Sorin Jianu
If you guys happen to be online and you could do the review, perhaps we ...
7 years ago (2013-12-15 23:05:59 UTC) #2
Sorin Jianu
https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_service.cc File chrome/browser/component_updater/component_updater_service.cc (right): https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_service.cc#newcode957 chrome/browser/component_updater/component_updater_service.cc:957: component_updater::DeleteFileAndParentDirectoryIfEmpty(crx_path); I will add a unit test to verify ...
7 years ago (2013-12-15 23:12:35 UTC) #3
Sorin Jianu
https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_service.cc File chrome/browser/component_updater/component_updater_service.cc (right): https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_service.cc#newcode957 chrome/browser/component_updater/component_updater_service.cc:957: component_updater::DeleteFileAndParentDirectoryIfEmpty(crx_path); On 2013/12/15 23:12:35, Sorin Jianu wrote: > I ...
7 years ago (2013-12-15 23:15:15 UTC) #4
waffles
lgtm https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_utils.h File chrome/browser/component_updater/component_updater_utils.h (right): https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_utils.h#newcode62 chrome/browser/component_updater/component_updater_utils.h:62: // Deletes the file and its directory, if ...
7 years ago (2013-12-16 17:42:39 UTC) #5
Sorin Jianu
TY! https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_utils.h File chrome/browser/component_updater/component_updater_utils.h (right): https://codereview.chromium.org/113533004/diff/20001/chrome/browser/component_updater/component_updater_utils.h#newcode62 chrome/browser/component_updater/component_updater_utils.h:62: // Deletes the file and its directory, if ...
7 years ago (2013-12-16 18:06:17 UTC) #6
waffles
lgtm
7 years ago (2013-12-16 19:04:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/113533004/60001
7 years ago (2013-12-16 19:42:48 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=205069
7 years ago (2013-12-16 20:54:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/113533004/60001
7 years ago (2013-12-16 21:07:40 UTC) #10
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/113533004/diff/60001/chrome/browser/component_updater/component_updater_utils.cc File chrome/browser/component_updater/component_updater_utils.cc (right): https://codereview.chromium.org/113533004/diff/60001/chrome/browser/component_updater/component_updater_utils.cc#newcode121 chrome/browser/component_updater/component_updater_utils.cc:121: I hope we don't end up deleting %temp% ...
7 years ago (2013-12-17 00:48:38 UTC) #11
Sorin Jianu
https://codereview.chromium.org/113533004/diff/60001/chrome/browser/component_updater/component_updater_utils.cc File chrome/browser/component_updater/component_updater_utils.cc (right): https://codereview.chromium.org/113533004/diff/60001/chrome/browser/component_updater/component_updater_utils.cc#newcode121 chrome/browser/component_updater/component_updater_utils.cc:121: On 2013/12/17 00:48:38, cpu wrote: > I hope we ...
7 years ago (2013-12-17 01:19:40 UTC) #12
commit-bot: I haz the power
7 years ago (2013-12-17 03:48:46 UTC) #13
Message was sent while issue was closed. 
Change committed as 241142

Powered by Google App Engine
This is Rietveld 408576698