Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1135323002: Revert of Have Notifications appear over docked windows (Closed)

Created:
5 years, 7 months ago by jonross
Modified:
5 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Have Notifications appear over docked windows (patchset #4 id:60001 of https://codereview.chromium.org/1121893004/) Reason for revert: varkha@ noticed that this change will cause the virtual keyboard to obscure the notifications. Which I confirmed on my local branch. Reverting before the regression is released. I'll work on a followup change that also accounts for the keyboard region. Original issue's description: > Have Notifications appear over docked windows > > Update AshPopupAlignmentDelegate calculations of its work area. > > When windows are docked this reduces the work area for windows. > AshPopupAlignmentDelegate uses the work area to determine the positioning of > notifications. Update this calculation to include the docked region. > > TEST=AshPopupAlignmentDelegateTest.DockedWindow > BUG=284574 > > Committed: https://crrev.com/5b4e72c6ad0924d64d5eb9a10e063bc9334e95b2 > Cr-Commit-Position: refs/heads/master@{#329486} TBR=oshima@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=284574 Committed: https://crrev.com/d42d4b2b547f8adbc7ac47e3eb20085901217f63 Cr-Commit-Position: refs/heads/master@{#329508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M ash/shelf/shelf_layout_manager.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.cc View 3 chunks +26 lines, -6 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of Have Notifications appear over docked windows
5 years, 7 months ago (2015-05-12 22:18:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135323002/1
5 years, 7 months ago (2015-05-12 22:20:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 22:22:36 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 22:23:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d42d4b2b547f8adbc7ac47e3eb20085901217f63
Cr-Commit-Position: refs/heads/master@{#329508}

Powered by Google App Engine
This is Rietveld 408576698