Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1135313003: [Android] Disable smart selection by default (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Disable smart selection by default There are ongoing improvements to smart selection that likely will not land before M44 branch. Disable it for now, avoiding the need to cherry-pick any eventual updates. BUG=451255 Committed: https://crrev.com/9a6cbec6b716f5fc55d1037bf5ae9b7ebd68ac45 Cr-Commit-Position: refs/heads/master@{#329721}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Disable by default #

Patch Set 3 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M content/renderer/render_view_impl.cc View 1 2 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jdduke (slow)
+mfomitchev to make sure this is what we discussed. +boliu for android_webview +sievers for content/renderer
5 years, 7 months ago (2015-05-12 22:10:53 UTC) #2
mfomitchev
LGTM with a nit https://codereview.chromium.org/1135313003/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/1135313003/diff/1/content/renderer/render_view_impl.cc#newcode763 content/renderer/render_view_impl.cc:763: if (selection_strategy_str == "character") Nit: ...
5 years, 7 months ago (2015-05-12 22:17:23 UTC) #3
jdduke (slow)
On 2015/05/12 22:17:23, mfomitchev wrote: > LGTM with a nit > > https://codereview.chromium.org/1135313003/diff/1/content/renderer/render_view_impl.cc > File ...
5 years, 7 months ago (2015-05-12 22:27:44 UTC) #4
no sievers
lgtm
5 years, 7 months ago (2015-05-13 21:49:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135313003/40001
5 years, 7 months ago (2015-05-13 21:53:05 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 22:00:11 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 22:01:14 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9a6cbec6b716f5fc55d1037bf5ae9b7ebd68ac45
Cr-Commit-Position: refs/heads/master@{#329721}

Powered by Google App Engine
This is Rietveld 408576698