Issue 1135293003: Update safe_math_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1135293003: Update safe_math_impl.h (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow

Modified:
5 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Update safe_math_impl.h Porting Chromium's https://codereview.chromium.org/1142783002/ to fix a division-by-zero bug. BUG=chromium:488302 LOG=n Committed: https://crrev.com/e5227ba5c3f7db6bb09787fc765d6df31bde1b3f Cr-Commit-Position: refs/heads/master@{#28475}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/base/safe_math_impl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135293003/1

5 years, 7 months ago (2015-05-19 10:42:20 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 11:09:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e5227ba5c3f7db6bb09787fc765d6df31bde1b3f
Cr-Commit-Position: refs/heads/master@{#28475}