Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1135263002: stop using (deprecated) SkScalarDiv (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

stop using (deprecated) SkScalarDiv BUG= Committed: https://crrev.com/0a5200b81089c2b4ee4da8cc9aa527a7098ea18b Cr-Commit-Position: refs/heads/master@{#329420}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M ui/views/color_chooser/color_chooser_view.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M ui/views/controls/progress_bar.cc View 2 chunks +3 lines, -6 lines 1 comment Download

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135263002/1
5 years, 7 months ago (2015-05-12 12:37:34 UTC) #2
reed1
need OWNER review for refactoring in ui/views
5 years, 7 months ago (2015-05-12 13:04:47 UTC) #4
reed1
needed to land this Skia CL https://codereview.chromium.org/1135053002/
5 years, 7 months ago (2015-05-12 13:33:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 13:42:46 UTC) #7
sky
https://codereview.chromium.org/1135263002/diff/1/ui/views/controls/progress_bar.cc File ui/views/controls/progress_bar.cc (right): https://codereview.chromium.org/1135263002/diff/1/ui/views/controls/progress_bar.cc#newcode243 ui/views/controls/progress_bar.cc:243: SkScalar border_width = kBorderWidth / scalar_height; SKIntToScale(kBorderWidth) here and ...
5 years, 7 months ago (2015-05-12 15:46:54 UTC) #8
reed1
I can restore the SkIntToScalar() macros, but they are no longer needed (we are removing ...
5 years, 7 months ago (2015-05-12 15:57:06 UTC) #9
sky
Ah, ok, LGTM
5 years, 7 months ago (2015-05-12 16:06:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135263002/1
5 years, 7 months ago (2015-05-12 16:40:56 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 16:44:35 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:45:18 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0a5200b81089c2b4ee4da8cc9aa527a7098ea18b
Cr-Commit-Position: refs/heads/master@{#329420}

Powered by Google App Engine
This is Rietveld 408576698