Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2636)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 1135253004: Remove the no longer used kPACE connection option. No functional change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rename_local_variable_93431527
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 13b21fc6befdd6d52c09bc9172ce97928087e8d9..03e3dc4aea2e0524c99b166a38aa9cce87631663 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -80,7 +80,6 @@ class IOThreadTest : public testing::Test {
};
TEST_F(IOThreadTest, InitializeNetworkSessionParamsFromGlobals) {
- globals_.quic_connection_options.push_back(net::kPACE);
globals_.quic_connection_options.push_back(net::kTBBR);
globals_.quic_connection_options.push_back(net::kTIME);
@@ -220,17 +219,6 @@ TEST_F(IOThreadTest, EnableQuicFromCommandLine) {
EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
}
-TEST_F(IOThreadTest, EnablePacingFromCommandLine) {
- command_line_.AppendSwitch("enable-quic");
- command_line_.AppendSwitch("enable-quic-pacing");
-
- ConfigureQuicGlobals();
- net::HttpNetworkSession::Params params;
- InitializeNetworkSessionParams(&params);
- net::QuicTagVector options;
- options.push_back(net::kPACE);
- EXPECT_EQ(options, params.quic_connection_options);
-}
TEST_F(IOThreadTest, DisableInsecureQuicFromFieldTrialParams) {
field_trial_group_ = "Enabled";
field_trial_params_["disable_insecure_quic"] = "true";
@@ -241,18 +229,6 @@ TEST_F(IOThreadTest, DisableInsecureQuicFromFieldTrialParams) {
EXPECT_TRUE(params.disable_insecure_quic);
}
-TEST_F(IOThreadTest, EnablePacingFromFieldTrialParams) {
- field_trial_group_ = "Enabled";
- field_trial_params_["enable_pacing"] = "true";
-
- ConfigureQuicGlobals();
- net::HttpNetworkSession::Params params;
- InitializeNetworkSessionParams(&params);
- net::QuicTagVector options;
- options.push_back(net::kPACE);
- EXPECT_EQ(options, params.quic_connection_options);
-}
-
TEST_F(IOThreadTest, PacketLengthFromCommandLine) {
command_line_.AppendSwitch("enable-quic");
command_line_.AppendSwitchASCII("quic-max-packet-length", "1450");
@@ -303,14 +279,13 @@ TEST_F(IOThreadTest, QuicVersionFromFieldTrialParams) {
TEST_F(IOThreadTest, QuicConnectionOptionsFromCommandLine) {
command_line_.AppendSwitch("enable-quic");
command_line_.AppendSwitchASCII("quic-connection-options",
- "PACE,TIME,TBBR,REJ");
+ "TIME,TBBR,REJ");
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
net::QuicTagVector options;
- options.push_back(net::kPACE);
options.push_back(net::kTIME);
options.push_back(net::kTBBR);
options.push_back(net::kREJ);
@@ -319,14 +294,13 @@ TEST_F(IOThreadTest, QuicConnectionOptionsFromCommandLine) {
TEST_F(IOThreadTest, QuicConnectionOptionsFromFieldTrialParams) {
field_trial_group_ = "Enabled";
- field_trial_params_["connection_options"] = "PACE,TIME,TBBR,REJ";
+ field_trial_params_["connection_options"] = "TIME,TBBR,REJ";
ConfigureQuicGlobals();
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
net::QuicTagVector options;
- options.push_back(net::kPACE);
options.push_back(net::kTIME);
options.push_back(net::kTBBR);
options.push_back(net::kREJ);
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698