Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1135243005: Adding new comment-matching regex to help license check with assembly files. (Closed)

Created:
5 years, 7 months ago by chcunningham
Modified:
5 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, DaleCurtis, watk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding new comment-matching regex to help license check with assembly files. For example: - third_party/ffmpeg/libavcodec/arm/hpeldsp_arm.S - third_party/ffmpeg/libavcodec/x86/xvididct.asm Committed: https://crrev.com/4c74623e0c48f641e33f832aadf114257f8e87ca Cr-Commit-Position: refs/heads/master@{#329775}

Patch Set 1 #

Patch Set 2 : Keeping removal of c comments after removal of new lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/devscripts/licensecheck.pl View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chcunningham
Hi Paweł, This changes comes from my work to audit ffmpeg, where have various assembly ...
5 years, 7 months ago (2015-05-12 21:42:32 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 7 months ago (2015-05-13 16:03:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135243005/20001
5 years, 7 months ago (2015-05-14 01:16:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 01:40:08 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 01:40:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c74623e0c48f641e33f832aadf114257f8e87ca
Cr-Commit-Position: refs/heads/master@{#329775}

Powered by Google App Engine
This is Rietveld 408576698