Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: src/ast-numbering.cc

Issue 1135243004: [es6] Support super.property in eval and arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: i have no idea Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast.cc ('k') | src/ast-value-factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast-numbering.cc
diff --git a/src/ast-numbering.cc b/src/ast-numbering.cc
index 35b8cef4f1e2cc695e80cd980158245bc2d3e9ef..f2fa7a8aa549c4c000f641af6c8b94db94782768 100644
--- a/src/ast-numbering.cc
+++ b/src/ast-numbering.cc
@@ -167,9 +167,8 @@ void AstNumberingVisitor::VisitThisFunction(ThisFunction* node) {
void AstNumberingVisitor::VisitSuperReference(SuperReference* node) {
IncrementNodeCount();
DisableOptimization(kSuperReference);
- ReserveFeedbackSlots(node);
- node->set_base_id(ReserveIdRange(SuperReference::num_ids()));
Visit(node->this_var());
+ Visit(node->home_object_var());
}
@@ -513,6 +512,8 @@ bool AstNumberingVisitor::Renumber(FunctionLiteral* node) {
DisableOptimization(kContextAllocatedArguments);
}
+ ReserveFeedbackSlots(node);
arv (Not doing code reviews) 2015/05/13 15:16:44 I'm confused by this. It passes my super tests but
+
VisitDeclarations(scope->declarations());
if (scope->is_function_scope() && scope->function() != NULL) {
// Visit the name of the named function expression.
« no previous file with comments | « src/ast.cc ('k') | src/ast-value-factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698