Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1135243002: [turbofan] Correctify FrameState before operations in JSTypeFeedbackSpecializer. (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Correctify FrameState before operations in JSTypeFeedbackSpecializer. Handle missing or improper FrameStates more gracefully. Uses the operator properties to determine if the node contains a FrameState before, then checks if a valid bailout id exists. R=jarin@chromium.org BUG= Committed: https://crrev.com/7f2636e0677193e916dca36a45f6ad6eb5e47efa Cr-Commit-Position: refs/heads/master@{#28364}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M src/compiler/js-type-feedback.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 1 7 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 7 months ago (2015-05-12 12:14:49 UTC) #1
Jarin
lgtm, even though it might be a bit brittle to assume that if there are ...
5 years, 7 months ago (2015-05-12 12:22:12 UTC) #2
titzer
On 2015/05/12 12:22:12, jarin wrote: > lgtm, even though it might be a bit brittle ...
5 years, 7 months ago (2015-05-12 12:29:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135243002/20001
5 years, 7 months ago (2015-05-12 12:55:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 12:57:38 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 12:57:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f2636e0677193e916dca36a45f6ad6eb5e47efa
Cr-Commit-Position: refs/heads/master@{#28364}

Powered by Google App Engine
This is Rietveld 408576698